appnet: add --east-west-gateway and --private-connect-subnet arguments to appnet member join and appnet member update#9673
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| appnet member join | cmd appnet member join added parameter east_west_gateway |
||
| appnet member join | cmd appnet member join added parameter private_connect_subnet |
||
| appnet member join | cmd appnet member join update parameter release_channel: added property choices=['Rapid', 'Stable'] |
||
| appnet member update | cmd appnet member update added parameter east_west_gateway |
|
Hi @german1608, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
There was a problem hiding this comment.
Pull request overview
Updates the appnet-preview extension’s generated AAZ specifications and scenario tests ahead of public preview, including new connectivity/upgrade profile shapes and corresponding CLI surface updates.
Changes:
- Bump extension version to
1.0.0b2and add release notes. - Update member join/update AAZ models to use
connectivityProfile+upgradeProfileand add new CLI arguments. - Refresh scenario tests and recordings to align with the updated API response shapes.
Reviewed changes
Copilot reviewed 12 out of 15 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/appnet-preview/setup.py | Bumps extension version to 1.0.0b2. |
| src/appnet-preview/HISTORY.rst | Documents new CLI arguments for member join/update. |
| src/appnet-preview/azext_appnet_preview/tests/latest/test_appnet_preview.py | Updates tests to use {location} and new response JSON paths for upgrade profile. |
| src/appnet-preview/azext_appnet_preview/tests/latest/recordings/test_appnet_list_versions.yaml | Updates recorded response content for list-versions. |
| src/appnet-preview/azext_appnet_preview/tests/latest/recordings/test_appnet_list_no_resources.yaml | Refreshes recording timestamps/headers. |
| src/appnet-preview/azext_appnet_preview/tests/latest/recordings/test_appnet_create.yaml | Refreshes create recording (includes additional polling interactions). |
| src/appnet-preview/azext_appnet_preview/aaz/latest/appnet/_create.py | Renames create operation to CreateOrUpdate (generated AAZ surface). |
| src/appnet-preview/azext_appnet_preview/aaz/latest/appnet/member/_join.py | Adds connectivity/upgrade args and updates request/response schema to new profile structure. |
| src/appnet-preview/azext_appnet_preview/aaz/latest/appnet/member/_update.py | Updates update schema and request shaping to new connectivityProfile/upgradeProfile. |
| src/appnet-preview/azext_appnet_preview/aaz/latest/appnet/member/_show.py | Updates response schema to new profile structure. |
| src/appnet-preview/azext_appnet_preview/aaz/latest/appnet/member/_list.py | Updates response schema to new profile structure. |
| src/appnet-preview/azext_appnet_preview/aaz/latest/appnet/member/_wait.py | Updates response schema to new profile structure. |
src/appnet-preview/azext_appnet_preview/aaz/latest/appnet/member/_join.py
Show resolved
Hide resolved
src/appnet-preview/azext_appnet_preview/aaz/latest/appnet/member/_join.py
Outdated
Show resolved
Hide resolved
src/appnet-preview/azext_appnet_preview/aaz/latest/appnet/member/_join.py
Show resolved
Hide resolved
src/appnet-preview/azext_appnet_preview/aaz/latest/appnet/member/_update.py
Show resolved
Hide resolved
src/appnet-preview/azext_appnet_preview/aaz/latest/appnet/member/_update.py
Show resolved
Hide resolved
src/appnet-preview/azext_appnet_preview/aaz/latest/appnet/member/_update.py
Outdated
Show resolved
Hide resolved
--east-west-gateway and --private-connect-subnet arguments to appnet member join and appnet member update
|
[Release] Update index.json for extension [ appnet-preview-1.0.0b2 ] : https://dev.azure.com/msazure/One/_build/results?buildId=157805600&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.